linux-kernel - Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171013110320.GA28151@krava>
Date:   Fri, 13 Oct 2017 13:03:20 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Milian Wolff <milian.wolff@...b.com>
Cc:     Namhyung Kim <namhyung@...nel.org>, acme@...nel.org,
        jolsa@...nel.org, Jin Yao <yao.jin@...ux.intel.com>,
        Linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        kernel-team@....com
Subject: Re: [PATCH v5 16/16] perf util: use correct IP mapping to find
 srcline for hist entry

On Thu, Oct 12, 2017 at 08:52:18PM +0200, Jiri Olsa wrote:
> On Thu, Oct 12, 2017 at 08:22:58PM +0200, Milian Wolff wrote:
> 
> SNIP
> 
> > > >  		return SRCLINE_UNKNOWN;
> > > > 
> > > > -	return get_srcline(map->dso, map__rip_2objdump(map, he->ip),
> > > > +	return get_srcline(map->dso, map__objdump_2mem(map, he->ip),
> > > > 
> > > >  			   he->ms.sym, true, true);
> > > 
> > > I'm not sure this is right.  IIRC hist_entry->ip is a relative IP so
> > > it needs to be changed for objdump use.  Maybe there's some bug on
> > > translating the address but it seems that the original code is
> > > correct.  And this change breaks srcline for my test program (which is
> > > a PIE).
> > 
> > Odd, I'll have to look at that. But this is imo unrelated to the rest of the 
> > patch series. So maybe we skip this one and apply the others. Assuming those 
> > other patches are OK by now?
> > 
> > Jiri, you also reviewed it before, is there anything else missing?
> 
> I plan to check on it this week.. sry for delay

I think Namhyung is right with his comment, the rest look ok,
so for patches 1 - 15:

Reviewed-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka