linux-kernel - Re: [PATCH] nvmem: meson: use generic compatible

Open Source and information security mailing list archives

Message-ID: <CAFBinCBVNEqTk+NUHz62FetLhYagFb5K+g17P_2Xb7sBUfEmdA@mail.gmail.com>
Date:   Fri, 13 Oct 2017 21:14:59 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>, devicetree@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] nvmem: meson: use generic compatible

Hi Jerome,

On Thu, Oct 12, 2017 at 5:24 PM, Jerome Brunet <jbrunet@...libre.com> wrote:
> The meson efuse driver seems to be compatible with more SoCs than
> initially thought. Let's use the most generic compatible he have in
> DT instead of the gxbb specific one
>
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>  Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt | 4 ++--
>  drivers/nvmem/meson-efuse.c                               | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> index fafd85bd67a6..0260524292fe 100644
> --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> @@ -1,7 +1,7 @@
>  = Amlogic eFuse device tree bindings =
>
>  Required properties:
> -- compatible: should be "amlogic,meson-gxbb-efuse"
> +- compatible: should be "amlogic,meson-gx-efuse"
have you checked with the devicetree maintainers how they want the
documentation to look like in this case?
(I don't know if the old one should be kept instead of removing it)

>
>  = Data cells =
>  Are child nodes of eFuse, bindings of which as described in
> @@ -10,7 +10,7 @@ bindings/nvmem/nvmem.txt
>  Example:
>
>         efuse: efuse {
> -               compatible = "amlogic,meson-gxbb-efuse";
> +               compatible = "amlogic,meson-gx-efuse";
>                 #address-cells = <1>;
>                 #size-cells = <1>;
>
> diff --git a/drivers/nvmem/meson-efuse.c b/drivers/nvmem/meson-efuse.c
> index 70bfc9839bb2..e90c6d68a263 100644
> --- a/drivers/nvmem/meson-efuse.c
> +++ b/drivers/nvmem/meson-efuse.c
> @@ -44,7 +44,7 @@ static struct nvmem_config econfig = {
>  };
>
>  static const struct of_device_id meson_efuse_match[] = {
> -       { .compatible = "amlogic,meson-gxbb-efuse", },
> +       { .compatible = "amlogic,meson-gx-efuse", },
>         { /* sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, meson_efuse_match);
> --
> 2.13.6
>
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives