linux-kernel - Re: [PATCH] x86/intel_cacheinfo: remove redundant assignment to this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171015204606.gs67hxz32g4skjca@pd.tnic>
Date:   Sun, 15 Oct 2017 22:46:06 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/intel_cacheinfo: remove redundant assignment to
 this_leaf

On Sun, Oct 15, 2017 at 05:02:03PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable this_leaf is being assigned a value that is never
> read and it is being updated a little later with a newer value,
> hence we can remove the redundant assignment.
> 
> Cleans up clang warning: Value stored to 'this_leaf' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/kernel/cpu/intel_cacheinfo.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
> index 24f749324c0f..9990a71e311f 100644
> --- a/arch/x86/kernel/cpu/intel_cacheinfo.c
> +++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
> @@ -831,7 +831,6 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index,
>  	} else if (boot_cpu_has(X86_FEATURE_TOPOEXT)) {
>  		unsigned int apicid, nshared, first, last;
>  
> -		this_leaf = this_cpu_ci->info_list + index;
>  		nshared = base->eax.split.num_threads_sharing + 1;
>  		apicid = cpu_data(cpu).apicid;
>  		first = apicid - (apicid % nshared);
> -- 

Looks ok to me.

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.