linux-kernel - [tip:x86/urgent] x86/cpu/intel_cacheinfo: Remove redundant assignment to 'this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 02:36:58 -0700
From:   tip-bot for Colin Ian King <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     torvalds@...ux-foundation.org, bp@...e.de, tglx@...utronix.de,
        colin.king@...onical.com, hpa@...or.com, mingo@...nel.org,
        peterz@...radead.org, linux-kernel@...r.kernel.org
Subject: [tip:x86/urgent] x86/cpu/intel_cacheinfo: Remove redundant
 assignment to 'this_leaf'

Commit-ID:  e6fc454b7794fc45c27364c7896b8f03094635ee
Gitweb:     https://git.kernel.org/tip/e6fc454b7794fc45c27364c7896b8f03094635ee
Author:     Colin Ian King <colin.king@...onical.com>
AuthorDate: Sun, 15 Oct 2017 17:02:03 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Mon, 16 Oct 2017 09:25:18 +0200

x86/cpu/intel_cacheinfo: Remove redundant assignment to 'this_leaf'

The 'this_leaf' variable is assigned a value that is never
read and it is updated a little later with a newer value,
hence we can remove the redundant assignment.

Cleans up the following Clang warning:

  Value stored to 'this_leaf' is never read

Signed-off-by: Colin Ian King <colin.king@...onical.com>
Reviewed-by: Borislav Petkov <bp@...e.de>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: kernel-janitors@...r.kernel.org
Link: http://lkml.kernel.org/r/20171015160203.12332-1-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/cpu/intel_cacheinfo.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 24f74932..9990a71 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -831,7 +831,6 @@ static int __cache_amd_cpumap_setup(unsigned int cpu, int index,
 	} else if (boot_cpu_has(X86_FEATURE_TOPOEXT)) {
 		unsigned int apicid, nshared, first, last;
 
-		this_leaf = this_cpu_ci->info_list + index;
 		nshared = base->eax.split.num_threads_sharing + 1;
 		apicid = cpu_data(cpu).apicid;
 		first = apicid - (apicid % nshared);