linux-kernel - Re: [PATCH] dmaengine: rcar-dmac: read DMATCRB instead of DMATCR for residue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87efq3mujz.wl%kuninori.morimoto.gx@renesas.com>
Date:   Mon, 16 Oct 2017 07:24:39 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        dmaengine@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@...esas.com>
Subject: Re: [PATCH] dmaengine: rcar-dmac: read DMATCRB instead of DMATCR for residue


Hi Geert

> >> > SYS/RT/Audio DMAC have both TCR/TCRB register.
> >> > Its difference is transfer counter value of read (= TCR)
> >> > or write (= TCRB). The relationship is like below.
> >> >
> >> >          TCR       TCRB
> >> >  [SOURCE] -> [DMAC] -> [DESTINATION]
> >> >
> >> > Thus, we want to read TCRB instead of TCR for residue.
> >> > Otherwise, Sound Capture has noise after PluseAudio support
> >> > (= 07b7acb51d2 ("ASoC: rsnd: update pointer more accurate"))
> >> >
> >> > Signed-off-by: Hiroyuki Yokoyama <hiroyuki.yokoyama.vx@...esas.com>
> >> > [Kuninori: added detail information in log]
> >> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > (snip)
> >> However, shouldn't the register to use depend on the DMA direction?
> >
> > I think TCRB is OK for all direction,
> > but yes, we can care its direction.
> > I can post v2 patch, if you want.
> > Geert do you want to care direction ?
> 
> Please do. I think in general the .get_residue() callback should return the
> correct value for both reading and writing.

OK, will post v2

Best regards
---
Kuninori Morimoto