linux-kernel - Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 15:36:50 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "mst@...hat.com" <mst@...hat.com>
CC:     "hch@....de" <hch@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "qla2xxx-upstream@...gic.com" <qla2xxx-upstream@...gic.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>
Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse
 endianness checks

On Mon, 2017-10-16 at 18:27 +0300, Michael S. Tsirkin wrote:
> On Mon, Oct 16, 2017 at 01:57:35PM +0000, Bart Van Assche wrote:
> > On Mon, 2017-10-16 at 16:34 +0300, Michael S. Tsirkin wrote:
> > > I don't see how it'll help make things better. OTOH if the specific
> > > drivers are tagged in the makefile, they can be gradually moved out to
> > > staging or something to help trigger action.
> > 
> > Do you really want to move drivers like qla2xxx to staging? That driver is
> > important to multiple enterprise distro's.
> 
> Frankly I'm surprised this one has sparse issues.
> Really e.g. drivers/scsi/qla2xxx/qla_nvme.h is new from June 2017.
> 
> It's not some ancient piece of code that no one understands so
> we are afraid to touch it.

Sorry if I wasn't clear enough but I wasn't referring to the qla2xxx NVMe
code. I was referring to the qla2xxx FC initiator code. I think that code
went upstream in January 2004. See also 
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/log/drivers/scsi/qla2xxx?ofs=100

Bart.