linux-kernel - Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 17:36:31 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "mst@...hat.com" <mst@...hat.com>
CC:     "hch@....de" <hch@....de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "qla2xxx-upstream@...gic.com" <qla2xxx-upstream@...gic.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse
 endianness checks

On Mon, 2017-10-16 at 19:50 +0300, Michael S. Tsirkin wrote:
> Right but qla_nvme also triggers these warnings. That's the problem with
> disabling them tree-wide. To me it looks like the time we are spending
> arguing about work-arounds would be better spent just fixing the
> majority of the code. If a couple of places aren't clean and
> need more thought, that's not a big deal.

Making the drivers that are not endianness clean mostly clean is risky. Such
changes would most likely be done by someone who is not the driver author.
Anyone who tries to fix endianness annotations without having a firmware
manual available risks to introduce incorrect endianness annotations. Such
annotations can make code more confusing instead of less.

Bart.