linux-kernel - Re: [PATCH] of: overlay: move resolve phandles into of_overlay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqL28_rr5CHMovr-k3h_Wyjpyf8xVia9Ffkcz_ZzGktCnA@mail.gmail.com>
Date:   Mon, 16 Oct 2017 15:46:53 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Frank Rowand <frowand.list@...il.com>
Cc:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        David Airlie <airlied@...ux.ie>, Jyri Sarha <jsarha@...com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] of: overlay: move resolve phandles into of_overlay_apply()

On Tue, Oct 10, 2017 at 8:02 PM,  <frowand.list@...il.com> wrote:
> From: Frank Rowand <frank.rowand@...y.com>
>
> Move more code into of_overlay_apply() so that it does not have
> to be duplicated by each caller of of_overlay_apply().
>
> The test in of_resolve_phandles() that the overlay tree is detached is
> temporarily disabled so that old style overlay unittests do not fail.
>
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---
>
> This patch applies on top of the series: "[PATCH 00/12] of: overlay: clean
> up device tree overlay code".
>
> While reviewing "[PATCH 09/12] of: overlay: avoid race condition between
> applying multiple overlays", Rob asked if of_resolve_phandles() could be
> moved into of_overlay_apply().  This patch is what is involved in doing so.

Looks fine. Can you squash this into patch 9 and resend the series (or
at least 9-12). The rest all looks fine to me.

Rob