[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <E7783A92-0174-47F6-86EC-8FECB8F79AEE@intel.com>
Date: Tue, 17 Oct 2017 22:58:41 +0000
From: "Dilger, Andreas" <andreas.dilger@...el.com>
To: "Gustavo A. R. Silva" <garsilva@...eddedor.com>
CC: "Drokin, Oleg" <oleg.drokin@...el.com>,
James Simmons <jsimmons@...radead.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Lustre Development List <lustre-devel@...ts.lustre.org>,
"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
"Shehata, Amir" <amir.shehata@...el.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 14/20] staging: lustre: lnet: selftest: mark expected
switch fall-throughs
On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote:
>
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>
> ---
> drivers/staging/lustre/lnet/selftest/module.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
> index b5d556f..fa1bccc 100644
> --- a/drivers/staging/lustre/lnet/selftest/module.c
> +++ b/drivers/staging/lustre/lnet/selftest/module.c
> @@ -57,10 +57,13 @@ lnet_selftest_exit(void)
> switch (lst_init_step) {
> case LST_INIT_CONSOLE:
> lstcon_console_fini();
> + /* fall through */
> case LST_INIT_FW:
> sfw_shutdown();
> + /* fall through */
> case LST_INIT_RPC:
> srpc_shutdown();
> + /* fall through */
> case LST_INIT_WI_TEST:
> for (i = 0;
> i < cfs_cpt_number(lnet_cpt_table()); i++) {
> @@ -72,7 +75,7 @@ lnet_selftest_exit(void)
> sizeof(lst_sched_test[0]) *
> cfs_cpt_number(lnet_cpt_table()));
> lst_sched_test = NULL;
> -
> + /* fall through */
> case LST_INIT_WI_SERIAL:
> cfs_wi_sched_destroy(lst_sched_serial);
> lst_sched_serial = NULL;
> --
> 2.7.4
>
Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation
Powered by blists - more mailing lists