lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Oct 2017 23:00:02 +0000 From: "Dilger, Andreas" <andreas.dilger@...el.com> To: "Gustavo A. R. Silva" <garsilva@...eddedor.com> CC: "Drokin, Oleg" <oleg.drokin@...el.com>, James Simmons <jsimmons@...radead.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 15/20] staging: lustre: llite: mark expected switch fall-through > On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com> Not sure why you moved the "for mode = 0" comment to a separate line? Not the end of the world though. Reviewed-by: Andreas Dilger <andreas.dilger@...el.com> > --- > drivers/staging/lustre/lustre/llite/namei.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lustre/llite/namei.c b/drivers/staging/lustre/lustre/llite/namei.c > index 5cc2b32..55e0d03 100644 > --- a/drivers/staging/lustre/lustre/llite/namei.c > +++ b/drivers/staging/lustre/lustre/llite/namei.c > @@ -949,7 +949,9 @@ static int ll_mknod(struct inode *dir, struct dentry *dchild, > > switch (mode & S_IFMT) { > case 0: > - mode |= S_IFREG; /* for mode = 0 case, fallthrough */ > + mode |= S_IFREG; > + /* for mode = 0 case */ > + /* fall through */ > case S_IFREG: > case S_IFCHR: > case S_IFBLK: > -- > 2.7.4 > Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation
Powered by blists - more mailing lists