linux-kernel - Re: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D8E42C0A-24EF-4312-9C0E-0D90BF296193@intel.com>
Date:   Tue, 17 Oct 2017 23:04:00 +0000
From:   "Dilger, Andreas" <andreas.dilger@...el.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
CC:     "Drokin, Oleg" <oleg.drokin@...el.com>,
        James Simmons <jsimmons@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 19/20] staging: lustre: ptlrpc: mark expected switch
 fall-throughs

On Oct 12, 2017, at 10:17, Gustavo A. R. Silva <garsilva@...eddedor.com> wrote:
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Reviewed-by: Andreas Dilger <andreas.dilger@...el.com>

> ---
> drivers/staging/lustre/lustre/ptlrpc/pack_generic.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> index aad4ff1..a3664c1 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/pack_generic.c
> @@ -786,7 +786,7 @@ __u32 lustre_msg_get_flags(struct lustre_msg *msg)
> 
> 		CERROR("invalid msg %p: no ptlrpc body!\n", msg);
> 	}
> -	/* no break */
> +	/* fall through */
> 	default:
> 		/* flags might be printed in debug code while message
> 		 * uninitialized
> @@ -854,7 +854,7 @@ __u32 lustre_msg_get_op_flags(struct lustre_msg *msg)
> 
> 		CERROR("invalid msg %p: no ptlrpc body!\n", msg);
> 	}
> -	/* no break */
> +	/* fall through */
> 	default:
> 		return 0;
> 	}
> @@ -1035,7 +1035,7 @@ int lustre_msg_get_status(struct lustre_msg *msg)
> 
> 		CERROR("invalid msg %p: no ptlrpc body!\n", msg);
> 	}
> -	/* no break */
> +	/* fall through */
> 	default:
> 		/* status might be printed in debug code while message
> 		 * uninitialized
> -- 
> 2.7.4
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation