linux-kernel - Re: [PATCH] staging/comedi: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb5b21d3-ea6d-2efb-5879-f88703b8cfa9@mev.co.uk>
Date:   Tue, 17 Oct 2017 10:28:57 +0100
From:   Ian Abbott <abbotti@....co.uk>
To:     Kees Cook <keescook@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     H Hartley Sweeten <hsweeten@...ionengravers.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/comedi: Convert timers to use timer_setup()

On 17/10/17 00:25, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer
> to all timer callbacks, switch to using the new timer_setup() and
> from_timer() to pass the timer pointer explicitly. Adds pointer back to
> comedi device from private struct.
> 
> Cc: Ian Abbott <abbotti@....co.uk>
> Cc: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: devel@...verdev.osuosl.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>   drivers/staging/comedi/drivers/comedi_test.c | 18 ++++++++++--------
>   drivers/staging/comedi/drivers/das16.c       | 11 ++++++-----
>   drivers/staging/comedi/drivers/jr3_pci.c     | 10 ++++++----
>   3 files changed, 22 insertions(+), 17 deletions(-)

It looks fine to me.

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-