lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Oct 2017 17:28:42 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Maxime Ripard <maxime.ripard@...e-electrons.com> Cc: Daniel Vetter <daniel.vetter@...el.com>, David Airlie <airlied@...ux.ie>, Chen-Yu Tsai <wens@...e.org>, dri-devel <dri-devel@...ts.freedesktop.org>, linux-kernel <linux-kernel@...r.kernel.org>, Mark Rutland <mark.rutland@....com>, Rob Herring <robh+dt@...nel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-clk <linux-clk@...r.kernel.org>, Priit Laes <plaes@...es.org>, Icenowy Zheng <icenowy@...c.io>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, Quentin Schulz <quentin.schulz@...e-electrons.com>, Mylene Josserand <mylene.josserand@...e-electrons.com> Subject: Re: [PATCH 05/23] drm/sun4i: tcon: Don't rely on encoders to enable the TCON On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard <maxime.ripard@...e-electrons.com> wrote: > So far, we've required all the TCON-connected encoders to call the TCON > enable and disable functions. > > This was made this way because in the RGB/LVDS case, the TCON is the CRTC > and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we > have another encoder down the road that needs to be programmed. > > We also needed to know which channel the encoder is connected to, which is > encoder-specific. > > The CRTC's enable and disable callbacks can work just fine for our use > case, and we can get the channel to use just by looking at the type of > encoder, since that is fixed. Implement those callbacks, which will > remove some of the encoder boilerplate. > > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com> Reviewed-by: Chen-Yu Tsai <wens@...e.org>
Powered by blists - more mailing lists