linux-kernel - Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9287b646-7673-bf5d-bcde-933c8c98a0dd@codeaurora.org>
Date:   Tue, 17 Oct 2017 10:06:39 -0400
From:   Tyler Baicar <tbaicar@...eaurora.org>
To:     Dongjiu Geng <gengdongjiu@...wei.com>, bp@...e.de,
        james.morse@....com, will.deacon@....com, rjw@...ysocki.net,
        lenb@...nel.org, robert.moore@...el.com, lv.zheng@...el.com,
        mark.rutland@....com, kristina.martsenko@....com, mingo@...nel.org,
        punit.agrawal@....com, stephen.boyd@...aro.org, kamensky@...co.com,
        prarit@...hat.com, shiju.jose@...wei.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, devel@...ica.or
Subject: Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for
 SEA/NMI notification type

On 10/17/2017 4:02 AM, Dongjiu Geng wrote:
> For the SEA notification, the two functions ghes_sea_add() and
> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
> is defined. If not, it will return errors in the ghes_probe()
> and not continue. If the probe is failed, the ghes_sea_remove()
> also has no chance to be called. Hence, remove the unnecessary
> handling when CONFIG_ACPI_APEI_SEA is not defined.
>
> For the NMI notification, it has the same issue as SEA notification,
> so also remove the unused dead-code for it.
>
> Cc: Tyler Baicar <tbaicar@...eaurora.org>
> Cc: James Morse <james.morse@....com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@...wei.com>
Tested-by: Tyler Baicar <tbaicar@...eaurora.org>

I've verified v5 of this series testing the SEA path.

Thanks,
Tyler