linux-kernel - Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171017164336.cedso3f35lpeam7f@pd.tnic>
Date:   Tue, 17 Oct 2017 18:43:36 +0200
From:   Borislav Petkov <bp@...e.de>
To:     Dongjiu Geng <gengdongjiu@...wei.com>
Cc:     tbaicar@...eaurora.org, james.morse@....com, will.deacon@....com,
        rjw@...ysocki.net, lenb@...nel.org, robert.moore@...el.com,
        lv.zheng@...el.com, mark.rutland@....com,
        kristina.martsenko@....com, mingo@...nel.org,
        punit.agrawal@....com, stephen.boyd@...aro.org, kamensky@...co.com,
        prarit@...hat.com, shiju.jose@...wei.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, devel@...ica.or
Subject: Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for
 SEA/NMI notification type

On Tue, Oct 17, 2017 at 04:02:20PM +0800, Dongjiu Geng wrote:
> @@ -1061,23 +1052,9 @@ static void ghes_nmi_init_cxt(void)
>  	init_irq_work(&ghes_proc_irq_work, ghes_proc_in_irq);
>  }
>  #else /* CONFIG_HAVE_ACPI_APEI_NMI */
> -static inline void ghes_nmi_add(struct ghes *ghes)
> -{
> -	pr_err(GHES_PFX "ID: %d, trying to add NMI notification which is not supported!\n",
> -	       ghes->generic->header.source_id);
> -	BUG();
> -}
> -
> -static inline void ghes_nmi_remove(struct ghes *ghes)
> -{
> -	pr_err(GHES_PFX "ID: %d, trying to remove NMI notification which is not supported!\n",
> -	       ghes->generic->header.source_id);
> -	BUG();
> -}
> -

So GHES NMI notification method is x86-only AFAIK and HAVE_ACPI_APEI_NMI
is selected only on x86. Why are you removing those guards? Does ARM
have ACPI_HEST_NOTIFY_NMI notification type now too?

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--