linux-kernel - Re: [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's drvdata

Open Source and information security mailing list archives

Date:   Wed, 18 Oct 2017 10:16:08 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     'Jeffy Chen' <jeffy.chen@...k-chips.com>
Cc:     Jingoo Han <jingoohan1@...il.com>, linux-kernel@...r.kernel.org,
        heiko@...ech.de, 'David Airlie' <airlied@...ux.ie>,
        rjw@...ysocki.net, dri-devel@...ts.freedesktop.org,
        'Andrzej Hajda' <a.hajda@...sung.com>,
        'Laurent Pinchart' <Laurent.pinchart@...asonboard.com>,
        'Marek Szyprowski' <m.szyprowski@...sung.com>,
        linux-samsung-soc@...r.kernel.org,
        'Joonyoung Shim' <jy0922.shim@...sung.com>,
        briannorris@...omium.org, 'Krzysztof Kozlowski' <krzk@...nel.org>,
        linux-rockchip@...ts.infradead.org,
        'Kukjin Kim' <kgene@...nel.org>,
        'Daniel Vetter' <daniel.vetter@...ll.ch>,
        'Caesar Wang' <wxt@...k-chips.com>,
        'Inki Dae' <inki.dae@...sung.com>, broonie@...nel.org,
        seanpaul@...omium.org, 'Vincent Abriou' <vincent.abriou@...com>,
        linux-arm-kernel@...ts.infradead.org,
        'Mark Yao' <mark.yao@...k-chips.com>,
        'zain wang' <wzz@...k-chips.com>,
        'Tomeu Vizoso' <tomeu.vizoso@...labora.com>,
        dmitry.torokhov@...il.com,
        'Seung-Woo Kim' <sw0312.kim@...sung.com>,
        dianders@...omium.org, tfiga@...omium.org,
        'Kyungmin Park' <kyungmin.park@...sung.com>
Subject: Re: [RFC PATCH v4 6/8] drm/bridge/analogix: Do not use device's
 drvdata

Hi,

On 10/18/2017 05:13 AM, Jingoo Han wrote:
> On Tuesday, October 17, 2017 6:16 AM, Jeffy Chen wrote:
>>
>> From: Tomasz Figa <tfiga@...omium.org>
>>
>> The driver that instantiates the bridge should own the drvdata, as all
>> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
>> owned by its driver struct. Moreover, storing two different pointer
>> types in driver data depending on driver initialization status is barely
>> a good practice and in fact has led to many bugs in this driver.
>>
>> Let's clean up this mess and change Analogix entry points to simply
>> accept some opaque struct pointer, adjusting their users at the same
>> time to avoid breaking the compilation.
>>
>> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
>> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
>> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> 

This depends on previous patches of the series. I guess it would be easier
to queue this to drm-misc as a part of the eDP support series. For that:

Acked-by: Archit Taneja <architt@...eaurora.org>

> Acked-by: Jingoo Han <jingoohan1@...il.com>
> 
> Best regards,
> Jingoo Han
> 
>> ---
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++--------
>> -----
>>   drivers/gpu/drm/exynos/exynos_dp.c                 | 26 ++++++-----
>>   drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    | 47
> +++++++++++-------
>> --
>>   include/drm/bridge/analogix_dp.h                   | 19 ++++----
>>   4 files changed, 73 insertions(+), 69 deletions(-)
>>
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives