linux-kernel - Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171018134718.GA32092@kroah.com>
Date:   Wed, 18 Oct 2017 15:47:18 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matthew Giassa <matthew@...ssa.net>
Cc:     devel@...verdev.osuosl.org, georgiana.chelu93@...il.com,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org,
        kvalo@...eaurora.org, davem@...emloft.net, khoroshilov@...ras.ru,
        Larry.Finger@...inger.net
Subject: Re: [PATCH] staging: rtlwifi: remove duplicated macros in comments

On Thu, Oct 05, 2017 at 04:44:31PM -0700, Matthew Giassa wrote:
> Removing a comment that duplicates definitions for pci_power_t
> enumeration, and pointing to the relevant header file (current comment
> is also missing PCI_POWER_ERROR).
> 
> Signed-off-by: Matthew Giassa <matthew@...ssa.net>
> ---
>  drivers/staging/rtlwifi/pci.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c
> index 4035b88..2e2cd21 100644
> --- a/drivers/staging/rtlwifi/pci.c
> +++ b/drivers/staging/rtlwifi/pci.c
> @@ -2456,12 +2456,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
>  #ifdef CONFIG_PM_SLEEP
>  /***************************************
>   * kernel pci power state define:
> - * PCI_D0         ((pci_power_t __force) 0)
> - * PCI_D1         ((pci_power_t __force) 1)
> - * PCI_D2         ((pci_power_t __force) 2)
> - * PCI_D3hot      ((pci_power_t __force) 3)
> - * PCI_D3cold     ((pci_power_t __force) 4)
> - * PCI_UNKNOWN    ((pci_power_t __force) 5)
> + * Refer to include/linux/pci.h

That's really vague, how about just deleting these lines, and the
previous one as well?

thanks,

greg k-h