linux-kernel - Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 11:25:08 +0100
From:   John Garry <john.garry@...wei.com>
To:     Tomasz Nowicki <tnowicki@...iumnetworks.com>,
        Jeremy Linton <jeremy.linton@....com>,
        <linux-acpi@...r.kernel.org>
CC:     <mark.rutland@....com>, <Jonathan.Zhang@...ium.com>,
        <Jayachandran.Nair@...ium.com>, <lorenzo.pieralisi@....com>,
        <austinwc@...eaurora.org>, <linux-pm@...r.kernel.org>,
        <jhugo@...eaurora.org>, <gregkh@...uxfoundation.org>,
        <sudeep.holla@....com>, <rjw@...ysocki.net>,
        <linux-kernel@...r.kernel.org>, <will.deacon@....com>,
        <wangxiongfeng2@...wei.com>, <viresh.kumar@...aro.org>,
        <hanjun.guo@...aro.org>, <catalin.marinas@....com>,
        <ahs3@...hat.com>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table
 parsing

On 19/10/2017 06:18, Tomasz Nowicki wrote:
>>
>> Summary:
>>
>> I'm not at all happy with this specification's attempt to leave out
>> pieces of information which make parsing things more deterministic. In
>> this case I'm happy to demote the message level, but not remove it
>> entirely but I do think the obvious case you list shouldn't be the
>> default one.
>>
>> Lastly:
>>
>> I'm assuming the final result is that the table is actually being
>> parsed correctly despite the ugly message?
>
> Indeed, the ThunderX2 PPTT table is being parsed so that topology shown
> in lstopo and lscpu is correct.

Hi Tomasz,

Can you share the lscpu output? Does it have cluster info? I did not 
think that lscpu has a concept of clustering.

I would say that the per-cpu cluster index sysfs entry needs be added to 
drivers/base/arch_topology.c (and other appropiate code under 
GENERIC_ARCH_TOPOLOGY) to support this.

Thanks,
John


>
> Thanks,
> Tomasz