linux-kernel - Re: [PATCH] printk: simplify no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNASLCtO1P2x0A0KgczqnsKYdYE4n9q0ACa4XuWnXZ8CxcA@mail.gmail.com>
Date:   Thu, 19 Oct 2017 19:48:15 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Petr Mladek <pmladek@...e.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk: simplify no_printk()

Hi Petr,

2017-10-02 23:56 GMT+09:00 Petr Mladek <pmladek@...e.com>:
> On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
>> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
>> a value") surrounded the macro implementation with ({ ... }).
>>
>> Now, the inner do { ... } while (0); is redundant.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> Looks fine to me. The return value is slightly more visible now ;-)
>
> Reviewed-by: Petr Mladek <pmladek@...e.com>
>
> JFYI, I have pushed it into for-4.15 branch.
>
> Best Regards,
> Petr


A minor problem.

I think "Reviewed-by: " is missing before Sergey.

I am not sure if this is too late, or not...




commit 38a8c55325f5d4f261fde8b1bebfa2e9daf7c3e1
Author: Masahiro Yamada <yamada.masahiro@...ionext.com>
Date:   Mon Sep 18 00:01:44 2017 +0900

    printk: simplify no_printk()

    Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
    a value") surrounded the macro implementation with ({ ... }).

    Now, the inner do { ... } while (0); is redundant.

    Link: http://lkml.kernel.org/r/1505660504-11059-1-git-send-email-yamada.masahiro@socionext.com
    Cc: Andrew Morton <akpm@...ux-foundation.org>
    Cc: Ingo Molnar <mingo@...nel.org>
    Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
    Cc: Steven Rostedt <rostedt@...dmis.org>
    Cc: linux-kernel@...r.kernel.org
    Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
    Sergey Senozhatsky <sergey.senozhatsky@...il.com>
    Signed-off-by: Petr Mladek <pmladek@...e.com>



-- 
Best Regards
Masahiro Yamada