linux-kernel - Re: [PATCH] tomoyo: fix timestamping for y2038

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 14:29:15 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     takedakn@...data.co.jp, james.l.morris@...cle.com,
        "Serge E. Hallyn" <serge@...lyn.com>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Ingo Molnar <mingo@...nel.org>,
        LSM List <linux-security-module@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tomoyo: fix timestamping for y2038

On Thu, Oct 19, 2017 at 1:29 PM, Tetsuo Handa
<penguin-kernel@...ove.sakura.ne.jp> wrote:
> Arnd Bergmann wrote:
>> Tomoyo uses an open-coded version of time_to_tm() to create a timestamp
>> from the current time as read by get_seconds(). This will overflow and
>> give wrong results on 32-bit systems in 2038.
>>

>
> Thank you.
>
> Please fold below diff into your patch, for year calculation is wrong.

Done, thanks for spotting this!

>
> Acked-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>

Thanks!

     Arnd