linux-kernel - Re: [PATCH v6 0/6] Add HiSilicon SoC uncore Performance Monitoring Unit driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 13:29:18 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Shaokun Zhang <zhangshaokun@...ilicon.com>, will.deacon@....com
Cc:     jonathan.cameron@...wei.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH v6 0/6] Add HiSilicon SoC uncore Performance Monitoring
 Unit driver

Will, are you happy to queue this?

There's a minor fixup [1] needed in patch 2, but otherwise this looks
good to me, and builds cleanly.

I've pushed out a branch [2] with that fix folded in, in case that's
easier for you. Otherwise, feel free to pick these up with my Ack.

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-October/538016.html
[2] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git perf-drivers/hisilicon-soc

On Thu, Oct 19, 2017 at 07:05:15PM +0800, Shaokun Zhang wrote:
> This patchset adds support for HiSilicon SoC uncore PMUs driver. It
> includes L3C, Hydra Home Agent (HHA) and DDRC.
> 
> Changes in v6:
> * remove redundant member hisi_pmu::oneline_cpus
> * rename member hisi_pmu::id
> * add event code check when event init
> * fix online/offline notifier for L3C/HHA/DDRC
> 
> Changes in v5:
> * remove unnecessary name/num_events member in hisi_pmu
> * refactor hisi_pmu_hwevents structure
> * remove hisi_pmu_alloc function
> * revise cpuhotplug for L3C PMUs
> * add cpuhotplug for HHA/DDRC PMUs
> * fix the name format of uncore PMUs
> * remove unnecessary variants
> 
> Changes in v4:
> * remove redundant code and comments
> * reverse the functions order in exit function
> * remove some GPL information
> * revise including header file
> * fix Jonathan's other comments
> 
> Changes in v3:
> * rebase to 4.13-rc1
> * add dev_err if ioremap fails for PMUs
>  
> Changes in v2:
> * fix kbuild test robot error
> * make hisi_uncore_ops static
> 
> Shaokun Zhang (6):
>   Documentation: perf: hisi: Documentation for HiSilicon SoC PMU driver
>   perf: hisi: Add support for HiSilicon SoC uncore PMU driver
>   perf: hisi: Add support for HiSilicon SoC L3C PMU driver
>   perf: hisi: Add support for HiSilicon SoC HHA PMU driver
>   perf: hisi: Add support for HiSilicon SoC DDRC PMU driver
>   arm64: MAINTAINERS: hisi: Add HiSilicon SoC PMU support
> 
>  Documentation/perf/hisi-pmu.txt               |  53 +++
>  MAINTAINERS                                   |   7 +
>  drivers/perf/Kconfig                          |   7 +
>  drivers/perf/Makefile                         |   1 +
>  drivers/perf/hisilicon/Makefile               |   1 +
>  drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 463 +++++++++++++++++++++++++
>  drivers/perf/hisilicon/hisi_uncore_hha_pmu.c  | 473 ++++++++++++++++++++++++++
>  drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c  | 463 +++++++++++++++++++++++++
>  drivers/perf/hisilicon/hisi_uncore_pmu.c      | 444 ++++++++++++++++++++++++
>  drivers/perf/hisilicon/hisi_uncore_pmu.h      | 102 ++++++
>  include/linux/cpuhotplug.h                    |   3 +
>  11 files changed, 2017 insertions(+)
>  create mode 100644 Documentation/perf/hisi-pmu.txt
>  create mode 100644 drivers/perf/hisilicon/Makefile
>  create mode 100644 drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
>  create mode 100644 drivers/perf/hisilicon/hisi_uncore_hha_pmu.c
>  create mode 100644 drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c
>  create mode 100644 drivers/perf/hisilicon/hisi_uncore_pmu.c
>  create mode 100644 drivers/perf/hisilicon/hisi_uncore_pmu.h
> 
> -- 
> 1.9.1
>