linux-kernel - Re: [PATCH] perf kmem: Perform some cleanup if '--time' is given an invalid value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171019123730.GJ3707@kernel.org>
Date:   Thu, 19 Oct 2017 09:37:30 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] perf kmem: Perform some cleanup if '--time' is given an
 invalid value

Em Sat, Sep 16, 2017 at 08:09:36AM +0200, Christophe JAILLET escreveu:
> If the string passed in '--time' is invalid, we must do some cleanup
> before leaving. As in the other error handling paths of this function.

Thanks, applied.

- Arnaldo
 
> Fixes: 2a865bd8dddd ("perf kmem: Add option to specify time window of interest")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  tools/perf/builtin-kmem.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index 24ee68ecdd42..d8f25ef8157b 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -1983,7 +1983,8 @@ int cmd_kmem(int argc, const char **argv)
>  
>  	if (perf_time__parse_str(&ptime, time_str) != 0) {
>  		pr_err("Invalid time string\n");
> -		return -EINVAL;
> +		ret = -EINVAL;
> +		goto out_delete;
>  	}
>  
>  	if (!strcmp(argv[0], "stat")) {
> -- 
> 2.11.0