linux-kernel - Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to be issued per lun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171019153510.GA7633@infradead.org>
Date:   Thu, 19 Oct 2017 08:35:10 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Cathy Avery <cavery@...hat.com>
Cc:     kys@...rosoft.com, hch@...radead.org, haiyangz@...rosoft.com,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        dan.carpenter@...cle.com, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH V2] scsi: storvsc: Allow only one remove lun work item to
 be issued per lun

On Tue, Oct 17, 2017 at 01:35:21PM -0400, Cathy Avery wrote:
> +	/*
> +	 * Set the error handler work queue.
> +	 */
> +	snprintf(host_dev->work_q_name, sizeof(host_dev->work_q_name),
> +		 "storvsc_error_wq_%d", host->host_no);
> +	host_dev->handle_error_wq =
> +			create_singlethread_workqueue(host_dev->work_q_name);

If you use alloc_ordered_workqueue directly instead of
create_singlethread_workqueue you can pass a format string and don't
need the separate allocation.

But I'm not sure if Tejun is fine with using __WQ_LEGACY directly..

Except for this nit this looks fine to me:

Reviewed-by: Christoph Hellwig <hch@....de>