linux-kernel - Re: [alsa-devel] [PATCH] ASoC: Intel: sst: remove redundant variable dma_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 11:33:29 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Colin King <colin.king@...onical.com>,
        Jie Yang <yang.jie@...ux.intel.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: sst: remove redundant variable
 dma_dev_name



On 10/19/2017 07:33 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The pointer dma_dev_name is assigned but never read, it is redundant
> and can therefore be removed.
>
> Cleans up clang warning:
> sound/soc/intel/common/sst-firmware.c:288:3: warning: Value stored to
> 'dma_dev_name' is never read
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Indeed this has been unused since at least 2015...
FWIW
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

> ---
>   sound/soc/intel/common/sst-firmware.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c
> index a086c35f91bb..79a9fdf94d38 100644
> --- a/sound/soc/intel/common/sst-firmware.c
> +++ b/sound/soc/intel/common/sst-firmware.c
> @@ -274,7 +274,6 @@ int sst_dma_new(struct sst_dsp *sst)
>   	struct sst_pdata *sst_pdata = sst->pdata;
>   	struct sst_dma *dma;
>   	struct resource mem;
> -	const char *dma_dev_name;
>   	int ret = 0;
>   
>   	if (sst->pdata->resindex_dma_base == -1)
> @@ -285,7 +284,6 @@ int sst_dma_new(struct sst_dsp *sst)
>   	* is attached to the ADSP IP. */
>   	switch (sst->pdata->dma_engine) {
>   	case SST_DMA_TYPE_DW:
> -		dma_dev_name = "dw_dmac";
>   		break;
>   	default:
>   		dev_err(sst->dev, "error: invalid DMA engine %d\n",