lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 20 Oct 2017 16:13:09 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Kan Liang <kan.liang@...el.com>
cc:     Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
        LKML <linux-kernel@...r.kernel.org>, acme@...nel.org,
        eranian@...gle.com, ak@...ux.intel.com
Subject: Re: [PATCH V2 2/4] perf/x86/intel/uncore: inline function to check
 the fixed counter event

On Thu, 19 Oct 2017, kan.liang@...el.com wrote:
> From: Kan Liang <Kan.liang@...el.com>
> 
> Remove the special codes in generic uncore_perf_event_update.

What are special codes?

> Introduce inline function to check the fixed counter event.
>  
> +static inline bool uncore_pmc_fixed(int idx)
> +{
> +	return (idx == UNCORE_PMC_IDX_FIXED);

The parentheses are pointless. Please get rid of them.

Thanks,

	tglx


Powered by blists - more mailing lists