linux-kernel - RE: [PATCH v10 13/15] platform/x86: wmi: create userspace interface for drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Oct 2017 14:15:00 +0000
From:   <Mario.Limonciello@...l.com>
To:     <greg@...ah.com>
CC:     <dvhart@...radead.org>, <andy.shevchenko@...il.com>,
        <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <luto@...nel.org>,
        <quasisec@...gle.com>, <pali.rohar@...il.com>, <rjw@...ysocki.net>,
        <mjg59@...gle.com>, <hch@....de>, <gnomes@...rguk.ukuu.org.uk>
Subject: RE: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
 for drivers

> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Friday, October 20, 2017 8:24 AM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: dvhart@...radead.org; Andy Shevchenko <andy.shevchenko@...il.com>;
> LKML <linux-kernel@...r.kernel.org>; platform-driver-x86@...r.kernel.org; Andy
> Lutomirski <luto@...nel.org>; quasisec@...gle.com; pali.rohar@...il.com;
> rjw@...ysocki.net; mjg59@...gle.com; hch@....de; Alan Cox
> <gnomes@...rguk.ukuu.org.uk>
> Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface for
> drivers
> 
> On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> > +#ifdef CONFIG_COMPAT
> > +	.compat_ioctl	= wmi_ioctl,
> 
> Why do you still need a compat ioctl?

Being able to run 32 bit app on 64 bit kernel.
Removing the .compat_ioctl definition and they fail.

So do you mean specifically the #ifdef CONFIG_COMPAT?
I do see that compat_ioctl is declared without it in linux/fs.h, but I'll admit
I'm unsure what happens if the kernel is compiled without CONFIG_COMPAT
and you try to run 32 bit apps.  _Should_ that work?