linux-kernel - Re: [PATCH V2 3/4] thermal/drivers/hisi: Prepare to add support for other hisi platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c202f396-fdc3-70cd-d762-71c088e04ba0@linaro.org>
Date:   Sat, 21 Oct 2017 10:14:33 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Eduardo Valentin <edubezval@...il.com>
Cc:     rui.zhang@...el.com, kevin.wangtao@...aro.org, leo.yan@...aro.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH V2 3/4] thermal/drivers/hisi: Prepare to add support for
 other hisi platforms

On 20/10/2017 22:58, Eduardo Valentin wrote:
> On Fri, Oct 20, 2017 at 05:11:06PM +0200, Daniel Lezcano wrote:
>> From: Kevin Wangtao <kevin.wangtao@...aro.org>
>>
>> For platform compatibility, add the tsensor ops to a thermal data
>> structure. Each platform has its own probe function to register proper
>> tsensor ops function to the pointer, platform related resource request
>> are also implemented in the platform probe function.
>>
>> Signed-off-by: Kevin Wangtao <kevin.wangtao@...aro.org>
>> Tested-by: Daniel Lezcano <daniel.lezcano@...aro.org> # hikey6220
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> 
> This patch adds this issue to hisi driver (sparse)
> 
> drivers/thermal/hisi_thermal.c:398:24: warning: incorrect type in assignment (different modifiers)
> drivers/thermal/hisi_thermal.c:398:24:    expected int ( *platform_probe )( ... )
> drivers/thermal/hisi_thermal.c:398:24:    got void const *
> 
> essentially you are casting a const into a non const.
> 
> Please fix and resend.

I was not able to reproduce the warning. I tried the C=1, C=2 options,
cross compiled or compiled on x86 with COMPILE_TEST, the warning does
not appear.

Are you using make C=1 or something else to run sparse on the kernel
sources ?



-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog