linux-kernel - Re: [PATCH v2 1/4] android: binder: Don't get mm from task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 Oct 2017 10:15:13 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sherry Yang <sherryy@...roid.com>
Cc:     linux-kernel@...r.kernel.org,
        "open list:ANDROID DRIVERS" <devel@...verdev.osuosl.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Riley Andrews <riandrews@...roid.com>, maco@...gle.com,
        tkjos@...gle.com
Subject: Re: [PATCH v2 1/4] android: binder: Don't get mm from task

On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote:
> Use binder_alloc struct's mm_struct rather than getting
> a reference to the mm struct through get_task_mm to
> avoid a potential deadlock between lru lock, task lock and
> dentry lock, since a thread can be holding the task lock
> and the dentry lock while trying to acquire the lru lock.
> 
> Acked-by: Arve Hjønnevåg <arve@...roid.com>
> Signed-off-by: Sherry Yang <sherryy@...roid.com>
> ---
>  drivers/android/binder_alloc.c | 22 +++++++++-------------
>  drivers/android/binder_alloc.h |  1 -
>  2 files changed, 9 insertions(+), 14 deletions(-)

I've applied these first 2 patches, but patches 3 and 4 I have already
applied to my char-misc-next tree, right?

thanks,

greg k-h