linux-kernel - Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 Oct 2017 18:18:03 +0800
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
CC:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Borislav Petkov <bp@...e.de>, "Len Brown" <lenb@...nel.org>,
        Tyler Baicar <tbaicar@...eaurora.org>,
        Will Deacon <will.deacon@....com>,
        Prarit Bhargava <prarit@...hat.com>,
        "ACPI Devel Maling List" <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for
 SEA/NMI notification type



On 2017/10/22 17:38, Rafael J. Wysocki wrote:
> On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng <gengdongjiu@...wei.com> wrote:
>> For the SEA notification, the two functions ghes_sea_add() and
>> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
>> is defined. If not, it will return errors in the ghes_probe()
>> and not continue. If the probe is failed, the ghes_sea_remove()
>> also has no chance to be called. Hence, remove the unnecessary
>> handling when CONFIG_ACPI_APEI_SEA is not defined.
>>
>> For the NMI notification, it has the same issue as SEA notification,
>> so also remove the unused dead-code for it.
>>
>> Cc: Tyler Baicar <tbaicar@...eaurora.org>
>> Cc: James Morse <james.morse@....com>
>> Signed-off-by: Dongjiu Geng <gengdongjiu@...wei.com>
>> Tested-by: Tyler Baicar <tbaicar@...eaurora.org>
>> Reviewed-by: Borislav Petkov <bp@...e.de>
> I applied one of the previous iterations.
> 
> Do I need to replace it with this version?

Rafael, I checked your applying, your applying is right. so no need to replace.
https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=3275fe60d1138e0cb57be9a3f46306b4d031c643
which is already "Reviewed-by: Borislav Petkov <bp@...e.de>"
Thanks

>