linux-kernel - Re: [PATCH] um: Use common error handling code in port_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171023084800.p26qcpb7iqyqrz4v@mwanda>
Date:   Mon, 23 Oct 2017 11:48:01 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     user-mode-linux-devel@...ts.sourceforge.net,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        user-mode-linux-user@...ts.sourceforge.net,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] um: Use common error handling code in port_listen_fd()

This business of moving the error code to the bottom of the function
just makes the code less readable.  I know you never listen to anyone,
but you should stop doing it.

regards,
dan carpenter