linux-kernel - Re: um: Use common error handling code in port_listen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e248c905-eb76-d9bd-6e10-92be8b200590@users.sourceforge.net>
Date:   Mon, 23 Oct 2017 11:01:05 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        user-mode-linux-devel@...ts.sourceforge.net
Cc:     Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>,
        user-mode-linux-user@...ts.sourceforge.net,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: um: Use common error handling code in port_listen_fd()

> This business of moving the error code to the bottom of the function
> just makes the code less readable.

I got an other software development opinion on this aspect.
Could you become used to the proposed control flow structure
in the affected function?

> I know you never listen to anyone,

My response times might not fir to your preferences.

> but you should stop doing it.

I am going to offer suggestions for change patterns which I find useful.
There are some challenges around change acceptance as usual.

Regards,
Markus