linux-kernel - Re: [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory Processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171023093104.GH32228@amd>
Date:   Mon, 23 Oct 2017 11:31:04 +0200
From:   Pavel Machek <pavel@....cz>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        Johan Hovold <johan@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [RESEND PATCH v7 1/1] platform: Add driver for RAVE Supervisory
 Processor

Hi!

> > >>  drivers/platform/Kconfig        |   2 +
> > >>  drivers/platform/Makefile       |   1 +
> > >>  drivers/platform/rave/Kconfig   |  26 ++
> > >>  drivers/platform/rave/Makefile  |   1 +
> > >>  drivers/platform/rave/rave-sp.c | 677 ++++++++++++++++++++++++++++++++++++++++
> > >
> > > First of all, why do these live in drivers/platform and why don't use
> > > the mfd subsystem to implement this driver (instead of rolling your own
> > > mfd-implementation)?
> > >
> > 
> > Because when I submitted this driver to MFD Lee Jones told me that it
> > didn't belong to that subsystem and should be added to the kernel in
> > "drivers/platform".
> 
> When I first reviewed this driver, it looked far too complex to be an
> MFD driver.  Most of the code doesn't deal with what I'd expect to be
> handled in MFD.  Why do you have ~600 lines of protocol handling?

Some drivers are more complex than other ones... I don't think that's
unexpected.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)