linux-kernel - Re: [PATCH] Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3add1a5c711650bde8226e483bc83a1e@dk-develop.de>
Date:   Tue, 24 Oct 2017 09:08:29 +0200
From:   Danilo Krummrich <danilokrummrich@...develop.de>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-input@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: ps2-gpio - actually abort probe when connected to
 sleeping GPIOs

On 2017-10-24 01:44, Dmitry Torokhov wrote:
> We've been missing a goto to the unwind path...
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/input/serio/ps2-gpio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/serio/ps2-gpio.c 
> b/drivers/input/serio/ps2-gpio.c
> index b50e3817f3c4..c62cceb97bb1 100644
> --- a/drivers/input/serio/ps2-gpio.c
> +++ b/drivers/input/serio/ps2-gpio.c
> @@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device 
> *pdev)
>  	    gpiod_cansleep(drvdata->gpio_clk)) {
>  		dev_err(dev, "GPIO data or clk are connected via slow bus\n");
>  		error = -EINVAL;
> +		goto err_free_serio;
Good catch, thanks.
>  	}
> 
>  	drvdata->irq = platform_get_irq(pdev, 0);
> --
> 2.15.0.rc0.271.g36b669edcc-goog