linux-kernel - Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171024092127.GB29656@lahna.fi.intel.com>
Date:   Tue, 24 Oct 2017 12:21:27 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Bin Meng <bmeng.cn@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stefan Roese <sr@...x.de>
Subject: Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote:
> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
> data. Select it in the Kconfig.
> 
> Signed-off-by: Bin Meng <bmeng.cn@...il.com>
> 
> ---
> 
> Changes in v2:
> - Enforce dependency on PCI
> 
>  drivers/mtd/spi-nor/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index f26aaa6..abf453a 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
>  
>  config SPI_INTEL_SPI_PLATFORM
>  	tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> -	depends on X86
> +	depends on X86 && PCI

It is kind of weird to depend on PCI if we want to enable *platform*
driver but whatever. I would still prefer to have dependency for LPC_ICH
instead.

No strong feelings though - as long as it builds and works fine :-)

>  	select SPI_INTEL_SPI
> +	select LPC_ICH
>  	help
>  	  This enables platform support for the Intel PCH/PCU SPI
>  	  controller in master mode. This controller is present in modern
> -- 
> 2.7.4