linux-kernel - Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2hJk_sLTtGik3qC+ZSADWqega3DK9HdSgYveuNfSk+zA@mail.gmail.com>
Date:   Tue, 24 Oct 2017 12:09:27 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Bin Meng <bmeng.cn@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stefan Roese <sr@...x.de>
Subject: Re: [PATCH v2] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH

On Tue, Oct 24, 2017 at 11:21 AM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Mon, Oct 23, 2017 at 11:59:39PM -0700, Bin Meng wrote:
>> index f26aaa6..abf453a 100644
>> --- a/drivers/mtd/spi-nor/Kconfig
>> +++ b/drivers/mtd/spi-nor/Kconfig
>> @@ -107,8 +107,9 @@ config SPI_INTEL_SPI_PCI
>>
>>  config SPI_INTEL_SPI_PLATFORM
>>       tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
>> -     depends on X86
>> +     depends on X86 && PCI
>
> It is kind of weird to depend on PCI if we want to enable *platform*
> driver but whatever. I would still prefer to have dependency for LPC_ICH
> instead.
>
> No strong feelings though - as long as it builds and works fine :-)

Agreed, I think we are better off using a dependency here, but
then we should probably do that for all users of LPC_ICH and
change them over as well. I think there are two or three other drivers
that currently select LPC_ICH. Using 'select' like this is generally
a bad idea, but being inconsistent (using both depends and select)
is usually worse.

        Arnd