linux-kernel - Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3afa825f-f851-e7df-bfa0-db5daa5d31fd@huawei.com>
Date:   Tue, 24 Oct 2017 18:41:02 +0800
From:   Chen Yu <chenyu56@...wei.com>
To:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     wangbinghui 00388012 <wangbinghui@...ilicon.com>
Subject: Re: [RFC 2/3] USB: dwc3: Modify dwc3 code for support usb of Hikey960


Hi, Felipe


 On 2017/10/24 16:25, Felipe Balbi wrote:
> Hi,
>
> Yu Chen <chenyu56@...wei.com> writes:
>> > The usb controller of Kirin960 is DesignWare Cores SuperSpeed USB 3.0 Controller.
>> > The patch modifies dwc3 for support Kirin960 and adds codes for a USB Hub on board Hikey960.
>> >
>> > Signed-off-by: Yu Chen 
> <chenyu56@...wei.com>
> > Signed-off-by: Ning Fan <fanning4@...ilicon.com>
> > Signed-off-by: Di Yang <yangdi10@...ilicon.com>
> > Signed-off-by: Rui Li <lirui39@...ilicon.com>
> I think Linaro, recently, added support for chargers to mainline. You
> should use what they did.
>
> I'm gonna stop here. There's no way I'm going through this much code in
> a single patch. Specially since 90% of it is either completely
> unnecessary or should be done using already-existing generic APIs.
>
> Sorry, no cookie today.

 Thanks a lot for your comments!
 These codes have been tested on Hikey960 board and work well. But indeed the codes can be simplified and
 made comply with already-existing architecture.
 We will work on these codes according to your reviews and make parted patch next time.

 Thanks,
 Yu Chen