linux-kernel - Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171024135511.773njwnmodnewtwo@linux.intel.com>
Date:   Tue, 24 Oct 2017 15:55:11 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-integrity@...r.kernel.org,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Peter Hüwe <PeterHuewe@....de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] tpm_tis_core: Use common error handling code in
 tpm_tis_send_data()

On Mon, Oct 23, 2017 at 03:51:09PM +0200, SF Markus Elfring wrote:
> >> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
> >>  
> >>  	return 0;
> >>  
> >> +report_timeout:
> >> +	rc = -ETIME;
> >>  out_err:
> >>  	tpm_tis_ready(chip);
> >>  	return rc;
> >> -- 
> >> 2.14.2
> >>
> > 
> > NAK. wait_for_tpm_stat() should give that error code.
> 
> This is a pity that you reject another bit of code reduction.
> 
> Regards,
> Markus

It is a pity that you continue doing this constant patch trolling.
That is what it is.

/Jarkko.