linux-kernel - Re: [PATCH] tpm_tis_core: Use common error handling code in tpm_tis_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <455e93f6-c419-8318-6129-80e99fc8552f@users.sourceforge.net>
Date:   Mon, 23 Oct 2017 15:51:09 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        linux-integrity@...r.kernel.org
Cc:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Peter Hüwe <PeterHuewe@....de>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] tpm_tis_core: Use common error handling code in
 tpm_tis_send_data()

>> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
>>  
>>  	return 0;
>>  
>> +report_timeout:
>> +	rc = -ETIME;
>>  out_err:
>>  	tpm_tis_ready(chip);
>>  	return rc;
>> -- 
>> 2.14.2
>>
> 
> NAK. wait_for_tpm_stat() should give that error code.

This is a pity that you reject another bit of code reduction.

Regards,
Markus