lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 24 Oct 2017 23:06:18 -0700
From:   Matthew Giassa <matthew@...ssa.net>
To:     gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, Matthew Giassa <matthew@...ssa.net>
Subject: [PATCH] staging: wlan-ng: resolve sparse endianness error.

Adding le16_to_cpu conversion in prism2sta.c, to resolve outstanding
sparse errors as noted in the current TODO in staging-next. Original
error:

  CHECK   drivers/staging//wlan-ng/prism2usb.c
drivers/staging//wlan-ng/prism2sta.c:1450:29: warning: incorrect type in assignment (different base types)
drivers/staging//wlan-ng/prism2sta.c:1450:29:    expected unsigned short [unsigned] [usertype] link_status_new
drivers/staging//wlan-ng/prism2sta.c:1450:29:    got restricted __le16 [usertype] linkstatus

Sparse error no longer present after change.

Signed-off-by: Matthew Giassa <matthew@...ssa.net>
---
 drivers/staging/wlan-ng/prism2sta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
index c9df450..070a237 100644
--- a/drivers/staging/wlan-ng/prism2sta.c
+++ b/drivers/staging/wlan-ng/prism2sta.c
@@ -1447,7 +1447,7 @@ static void prism2sta_inf_linkstatus(struct wlandevice *wlandev,
 {
 	struct hfa384x *hw = wlandev->priv;
 
-	hw->link_status_new = inf->info.linkstatus.linkstatus;
+	hw->link_status_new = le16_to_cpu(inf->info.linkstatus.linkstatus);
 
 	schedule_work(&hw->link_bh);
 }
-- 
2.7.4

Powered by blists - more mailing lists