linux-kernel - Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86efprfywz.fsf@arm.com>
Date:   Wed, 25 Oct 2017 08:51:24 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Antoine Tenart <antoine.tenart@...e-electrons.com>
Cc:     <tglx@...utronix.de>, <jason@...edaemon.net>,
        <gregory.clement@...e-electrons.com>, <andrew@...n.ch>,
        <sebastian.hesselbarth@...il.com>,
        <thomas.petazzoni@...e-electrons.com>,
        <miquel.raynal@...e-electrons.com>, <nadavh@...vell.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init

On Wed, Oct 25 2017 at  9:23:26 am BST, Antoine Tenart <antoine.tenart@...e-electrons.com> wrote:
> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>
> ---
>  drivers/irqchip/irq-mvebu-gicp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	gicp->dev = &pdev->dev;
> +	spin_lock_init(&gicp->spi_lock);
>  
>  	gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!gicp->res)

Cc: stable@...r.kernel.org
Acked-by: Marc Zyngier <marc.zyngier@....com>

Thomas, can you please queue this ASAP?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.