linux-kernel - Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Oct 2017 09:37:03 +0200
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Antoine Tenart <antoine.tenart@...e-electrons.com>
Cc:     tglx@...utronix.de, marc.zyngier@....com, jason@...edaemon.net,
        andrew@...n.ch, sebastian.hesselbarth@...il.com,
        thomas.petazzoni@...e-electrons.com,
        miquel.raynal@...e-electrons.com, nadavh@...vell.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] irqchip/irq-mvebu-gicp: add missing spin_lock init

Hi Antoine,
 
 On mer., oct. 25 2017, Antoine Tenart <antoine.tenart@...e-electrons.com> wrote:

> A spin lock is used in the irq-mvebu-gicp driver, but it is never
> initialized. This patch adds the missing spin_lock_init() call in the
> driver's probe function.
>
> Fixes: a68a63cb4dfc ("irqchip/irq-mvebu-gicp: Add new driver for Marvell GICP")
> Signed-off-by: Antoine Tenart <antoine.tenart@...e-electrons.com>

You could add the "Cc: stable@...r.kernel.org" flag so the previous
kernels can also benefit of this fix.

Besides this this patch looks obviously correct.

Reviewed-by: Gregory CLEMENT <gregory.clement@...e-electrons.com>

Thanks,

Gregory


> ---
>  drivers/irqchip/irq-mvebu-gicp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/irq-mvebu-gicp.c b/drivers/irqchip/irq-mvebu-gicp.c
> index b283fc90be1e..17a4a7b6cdbb 100644
> --- a/drivers/irqchip/irq-mvebu-gicp.c
> +++ b/drivers/irqchip/irq-mvebu-gicp.c
> @@ -194,6 +194,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	gicp->dev = &pdev->dev;
> +	spin_lock_init(&gicp->spi_lock);
>  
>  	gicp->res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	if (!gicp->res)
> -- 
> 2.14.2
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com