linux-kernel - Re: [PATCH AUTOSEL for 4.9 43/50] regulator: core: Don't use regulators as supplies until the parent is bound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171025080636.upxjx3ed3gvisnz4@sirena.org.uk>
Date:   Wed, 25 Oct 2017 10:06:36 +0200
From:   Mark Brown <broonie@...nel.org>
To:     "Levin, Alexander (Sasha Levin)" <alexander.levin@...izon.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH AUTOSEL for 4.9 43/50] regulator: core: Don't use
 regulators as supplies until the parent is bound

On Wed, Oct 25, 2017 at 01:56:02AM +0000, Levin, Alexander (Sasha Levin) wrote:

> When regulators are successfully registered, we check to see if the
> regulator is a supply for any other registered regulator and if so
> add the new regulator as the supply for the existing regulator(s).

This had some knock on effects which caused trouble for other things, 
for example 3827b64dba (regulator: core: Resolve supplies before
disabling unused regulators).  

In general I would be extremely wary of backporting anything like this
that affects things like device instantiation ordering, even without any
knock on bugs directly in the code there's a good chance that someone
building on stable is going to have some kind of dependency on the
particular behaviour of the kernel version they're using and changes
like this could cause updating to the latest stable to introduce
problems which then discourages people from picking up stable.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)