linux-kernel - Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Oct 2017 16:06:44 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Juergen Gross <jgross@...e.com>, <linux-kernel@...r.kernel.org>,
        <x86@...nel.org>
CC:     <hpa@...or.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
        <arnd@...db.de>, <peterz@...radead.org>
Subject: Re: [PATCH] paravirt/locks: avoid modifying static key before
 jump_label_init()

Hi Juergen,

>>
>> How about moving the check of xen_pvspin into native_pv_lock_init()
>> like below?
>
> This would leak xen_pvspin to non-Xen code. I'd rather do the

Oops, yes, I made the mistake. Please ignore it.

> static_branch_disable() in xen_init_lock_cpu() if cpu == 0.
>

Yes. I will test it. :-)

Thanks,
	dou.