lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171027084312.k2ay4pfh6h3ajatn@gmail.com>
Date:   Fri, 27 Oct 2017 10:43:12 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Juergen Gross <jgross@...e.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org, hpa@...or.com,
        tglx@...utronix.de, mingo@...hat.com, arnd@...db.de,
        peterz@...radead.org
Subject: Re: [PATCH] paravirt/locks: avoid modifying static key before
 jump_label_init()


* Juergen Gross <jgross@...e.com> wrote:

> Don't try to set the static virt_spin_lock_key to a value before
> jump_label_init() has been called, as this will result in a WARN().
> 
> Solve the problem by introducing a new lock_init() hook called after
> jump_label_init() instead of doing the call inside of
> smp_prepare_boot_cpu().
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>
> ---
> Based on kernel/git/tip/tip.git locking/core

Just a quick ping: what's the conclusion of the discussion, do we want this patch 
as-is?

Also, it's unclear from the changelog under what circumstances this bug was 
observed and what symptoms there are and how severe the bug - can the warning 
trigger on vanilla v4.14?

Thanks,

	Ingo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ