linux-kernel - Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171025145337.kubcbkxrhbsy6o4a@rob-hp-laptop>
Date:   Wed, 25 Oct 2017 09:53:37 -0500
From:   Rob Herring <robh@...nel.org>
To:     Raveendra Padasalagi <raveendra.padasalagi@...adcom.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional
 debounce-timeout-ms attribute

On Thu, Oct 19, 2017 at 08:55:59AM +0530, Raveendra Padasalagi wrote:
> Add documentation on optional dt attribute "debounce-timeout-ms"
> in extcon node to capture user specified timeout value for id
> and vbus gpio detection.
> 
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@...adcom.com>
> Reviewed-by: Ray Jui <ray.jui@...adcom.com>
> Reviewed-by: Srinath Mannam <srinath.mannam@...adcom.com>
> ---
> 
> Changes in v2:
>  Rename debounce-timeout-ms to input-debounce
> 
>  Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
>  1 file changed, 3 insertions(+)

Sorry, but extcon bindings should be scrapped IMO and I don't want to 
see additions. "extcon" is a Linuxism and is the first clue.

What's needed is a full USB connector binding, not just some incomplete 
handling of ID and Vbus pins. There's some work happening on that[1].

Rob

[1] https://www.spinics.net/lists/linux-usb/msg161106.html