linux-kernel - Re: [PATCH 1/8] SOC: brcmstb: add memory API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Oct 2017 11:00:32 -0400
From:   Jim Quinlan <jim2101024@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Brian Norris <computersforpeace@...il.com>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Robin Murphy <robin.murphy@....com>,
        Christoph Hellwig <hch@....de>,
        linux-pci <linux-pci@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        Kevin Cernekee <cernekee@...il.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Linux-MIPS <linux-mips@...ux-mips.org>,
        Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH 1/8] SOC: brcmstb: add memory API

On Tue, Oct 24, 2017 at 8:23 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> Hi Jim,
>
> On 10/24/2017 11:15 AM, Jim Quinlan wrote:
>> +#elif defined(CONFIG_MIPS)
>> +int brcmstb_memory_phys_addr_to_memc(phys_addr_t pa)
>> +{
>> +     /* The logic here is fairly simple and hardcoded: if pa <= 0x5000_0000,
>> +      * then this is MEMC0, else MEMC1.
>> +      *
>> +      * For systems with 2GB on MEMC0, MEMC1 starts at 9000_0000, with 1GB
>> +      * on MEMC0, MEMC1 starts at 6000_0000.
>> +      */
>> +     if (pa >= 0x50000000ULL)
>> +             return 1;
>> +     else
>> +             return 0;
>> +}
>> +#endif
>
> We may be missing an EXPORT_SYMBOL_GPL(brcmstb_memory_phys_to_addr_memc)
> here?
>
> Thanks!
> --
> Florian

Hi Florian,

I removed that EXPORT_SYMBOL_GPL() because this particular call is not
directly invoked PCIe RC driver.  It is indirectly invoked by
brcmstb_memory_memc_size(), which is exported.

Thanks, Jim