linux-kernel - Re: [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for RAVE SP watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqEHqdhUtPRUQG9KxbaRJXb_ZerhheO9R=eN=uDKpwT24g@mail.gmail.com>
Date:   Wed, 25 Oct 2017 08:00:32 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-watchdog@...r.kernel.org,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Johan Hovold <johan@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for RAVE SP
 watchdog driver

On Tue, Oct 24, 2017 at 12:07 PM, Rob Herring <robh@...nel.org> wrote:
> On Wed, Oct 18, 2017 at 10:01:36AM -0700, Andrey Smirnov wrote:
>
> Commit msg?
>

OK, will add in v9.

>> Cc: linux-kernel@...r.kernel.org
>> Cc: devicetree@...r.kernel.org
>> Cc: linux-watchdog@...r.kernel.org
>> Cc: cphealy@...il.com
>> Cc: Lucas Stach <l.stach@...gutronix.de>
>> Cc: Nikita Yushchenko <nikita.yoush@...entembedded.com>
>> Cc: Lee Jones <lee.jones@...aro.org>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Pavel Machek <pavel@....cz>
>> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
>> Cc: Guenter Roeck <linux@...ck-us.net>
>> Cc: Rob Herring <robh@...nel.org>
>> Cc: Johan Hovold <johan@...nel.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
>> ---
>>  Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt b/Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt
>> new file mode 100644
>> index 000000000000..f242c3eed0dc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/zii,rave-sp-wdt.txt
>> @@ -0,0 +1,10 @@
>> +Zodiac Inflight Innovations RAVE Supervisory Processor Watchdog
>> +
>> +Required properties:
>> +
>> + - compatible: Should be "zii,rave-sp-watchdog"
>> +
>
> Must be a child of ? defined in ?

Good point, will add.

>
>> +Optional properties:
>> +
>> + - Two byte nvmem cell "wdt_timeout", specified as per
>> +   Documentation/devicetree/bindings/nvmem/nvmem.txt
>
> prop name: definition... is the normal format.
>
> Also, don't use '_' in property names.
>

OK, will fix.

Thanks,
Andrey Smirnov