linux-kernel - Re: [PATCH v8 1/5] serdev: Make .remove in struct serdev_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171027181710.ne3ku6rysm4blqov@earth>
Date:   Fri, 27 Oct 2017 20:17:11 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        Rob Herring <robh@...nel.org>, cphealy@...il.com,
        Lucas Stach <l.stach@...gutronix.de>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pavel Machek <pavel@....cz>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v8 1/5] serdev: Make .remove in struct
 serdev_device_driver optional

Hi,

On Sat, Oct 21, 2017 at 10:08:40AM -0700, Guenter Roeck wrote:
> On 10/18/2017 10:01 AM, Andrey Smirnov wrote:
> > Using devres infrastructure it is possible to wirte a serdev driver
> 
> s/wirte/write/
> 
> otherwise
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

-- Sebastian

> > that doesn't have any code that needs to be called as a part of
> > .remove. Add code to make .remove optional.
> > 
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-serial@...r.kernel.org
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: cphealy@...il.com
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Lucas Stach <l.stach@...gutronix.de>
> > Cc: Nikita Yushchenko <nikita.yoush@...entembedded.com>
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: Pavel Machek <pavel@....cz>
> > Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> > Cc: Johan Hovold <johan@...nel.org>
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > ---
> >   drivers/tty/serdev/core.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> > index c68fb3a8ea1c..f500f6a2ca88 100644
> > --- a/drivers/tty/serdev/core.c
> > +++ b/drivers/tty/serdev/core.c
> > @@ -252,8 +252,8 @@ static int serdev_drv_probe(struct device *dev)
> >   static int serdev_drv_remove(struct device *dev)
> >   {
> >   	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
> > -
> > -	sdrv->remove(to_serdev_device(dev));
> > +	if (sdrv->remove)
> > +		sdrv->remove(to_serdev_device(dev));
> >   	return 0;
> >   }
> > 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)