linux-kernel - Re: [PATCH] iscsi-target: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1509026649.13829.0.camel@wdc.com>
Date:   Thu, 26 Oct 2017 14:04:13 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "keescook@...omium.org" <keescook@...omium.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jiangyilism@...il.com" <jiangyilism@...il.com>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "Jason@...c4.com" <Jason@...c4.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "varun@...lsio.com" <varun@...lsio.com>
Subject: Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

On Thu, 2017-10-26 at 10:24 +0200, Kees Cook wrote:
> On Wed, Oct 25, 2017 at 5:03 PM, Bart Van Assche <Bart.VanAssche@....com> wrote:
> > On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote:
> > > However, maintainers: sorry to send this one -- it can't be merged
> > > yet, this uses timer_setup_on_stack() which is only in -next right
> > > now. If it looks okay, though, I can carry this in the timer tree.
> > 
> > Hello Kees,
> > 
> > Can you have a look at the following patch and queue it before your
> > patch if you think this would be useful (this patch has been tested):
> > "target/iscsi: Simplify timer manipulation code"
> > (https://www.spinics.net/lists/target-devel/msg15385.html).
> 
> This looks good, yeah. Can you resend it with me CCed? It doesn't look
> like it was CCed to lkml, so it's not easy to for me to add it to me
> tree.

OK, I will resend that patch as a reply to this e-mail. BTW, I just finished
retesting that patch on top of v4.14-rc6.

Bart.