lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 26 Oct 2017 17:55:02 +0200 (CEST)
From:   Linus Torvalds <>
To:     Andy Lutomirski <>
cc:     X86 ML <>, Borislav Petkov <>,
        "" <>,
        Brian Gerst <>,
        Dave Hansen <>
Subject: Re: [PATCH 00/18] Pile o' entry/exit/sp0 changes

On Thu, 26 Oct 2017, Andy Lutomirski wrote:
> Here's the first "real" version of this series.  It's based on Linus'
> tree from a couple days ago.

Not seeing any problems in this series. I was hoping it would remove more 
lines of code than it adds, and it's the reverse, but that seems to be 
mostly the new push/pop stuff. I'm taking it we couldn't just replace the 
'mov' instructions in the save/restore macros..

I *do* ask that when we have code like this:

        addq    $8, %rsp

that "addq $8" would have a comment about what stack entry we're skipping.

I *think* it's 'orig_eax', but wouldn't it be nice to say so?


Powered by blists - more mailing lists